From 863d371c83fe8ca59f1a2cef3ce4d7b66b06dd99 Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Thu, 29 Jan 2015 11:32:42 +0100 Subject: [PATCH] sulogin: make sure that fallback FD is valid [coverity scan] Signed-off-by: Karel Zak --- login-utils/sulogin-consoles.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/login-utils/sulogin-consoles.c b/login-utils/sulogin-consoles.c index 817a882cf7..9fd1034056 100644 --- a/login-utils/sulogin-consoles.c +++ b/login-utils/sulogin-consoles.c @@ -594,7 +594,7 @@ int detect_consoles(const char *device, int fallback, struct list_head *consoles consoles_debug = getenv("CONSOLES_DEBUG") ? 1 : 0; if (!device || !*device) - fd = dup(fallback); + fd = fallback >= 0 ? dup(fallback) : - 1; else { fd = open(device, O_RDWR|O_NONBLOCK|O_NOCTTY|O_CLOEXEC); reconnect = 1; -- 2.47.3