From 87deeb2016cbfdaff5531e1badb58761af6df848 Mon Sep 17 00:00:00 2001 From: Belen Barros Pena Date: Mon, 26 Jan 2015 15:11:54 +0000 Subject: [PATCH] toastergui: consistent add / remove layer notifications In my struggle to ensure consistency in the format and content of the notifications we show when you add and remove layers to a project, I've: * added the project name to the notifications in the layer details page * removed the 'Go to project configuration' link from the notifications in the layer details page This changes align the notifications we show in the layer details page with the ones we show in the 'all' pages. Signed-off-by: Belen Barros Pena --- lib/toaster/toastergui/static/js/layerdetails.js | 10 ++++++---- lib/toaster/toastergui/templates/layerdetails.html | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/toaster/toastergui/static/js/layerdetails.js b/lib/toaster/toastergui/static/js/layerdetails.js index 41cbf4ba937..2addecd357d 100644 --- a/lib/toaster/toastergui/static/js/layerdetails.js +++ b/lib/toaster/toastergui/static/js/layerdetails.js @@ -211,7 +211,7 @@ function layerDetailsPageInit (ctx) { addRmLayerBtn.prepend(""); if (depsList) { - alertMsg.append("You have added "+(depsList.length+1)+" layers: and its dependencies "); + alertMsg.append("You have added "+(depsList.length+1)+" layers to : and its dependencies "); /* Build the layer deps list */ depsList.map(function(layer, i){ @@ -227,7 +227,7 @@ function layerDetailsPageInit (ctx) { alertMsg.append(link); }); } else { - alertMsg.append("You have added 1 layer: "); + alertMsg.append("You have added 1 layer to : "); } } else { /* disable and switch all the button states */ @@ -252,10 +252,12 @@ function layerDetailsPageInit (ctx) { break; } - alertMsg.append("You have deleted 1 layer: "); + alertMsg.append("You have deleted 1 layer from : "); } - alertMsg.children("#layer-affected-name").text(ctx.layerVersion.name); + alertMsg.children("#layer-affected-name").html("" + ctx.layerVersion.name + ""); + alertMsg.children("#project-affected-name").text(ctx.projectName); + alertMsg.children("#project-affected-name").attr("href", ctx.projectPageUrl); $("#alert-area").show(); } diff --git a/lib/toaster/toastergui/templates/layerdetails.html b/lib/toaster/toastergui/templates/layerdetails.html index 207197bce64..a89ffb03121 100644 --- a/lib/toaster/toastergui/templates/layerdetails.html +++ b/lib/toaster/toastergui/templates/layerdetails.html @@ -23,6 +23,7 @@ xhrDataTypeaheadUrl : "{% url 'xhr_datatypeahead' %}", xhrUpdateLayerUrl : "{% url 'xhr_updatelayer' %}", projectId : {{project.id}}, + projectName : "{{project.name}}", numTargets : {{total_targets}}, numMachines: {{machines|length}}, layerVersion : { @@ -73,7 +74,6 @@