From 88f560b6191ecb22c77032ca523fb100e7e23ec9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Mon, 28 Apr 2025 11:43:30 +0100 Subject: [PATCH] tests: storage hardcoding paths for mount & vgchange MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This is redundant since the tests will strip any path component from the binary name before comparison. Reviewed-by: Peter Krempa Signed-off-by: Daniel P. Berrangé --- tests/storagepoolxml2argvtest.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/tests/storagepoolxml2argvtest.c b/tests/storagepoolxml2argvtest.c index e8e40d695e..d5c2531ab8 100644 --- a/tests/storagepoolxml2argvtest.c +++ b/tests/storagepoolxml2argvtest.c @@ -6,14 +6,6 @@ #define VIR_FROM_THIS VIR_FROM_NONE -#ifndef MOUNT -# define MOUNT "/usr/bin/mount" -#endif - -#ifndef VGCHANGE -# define VGCHANGE "/usr/sbin/vgchange" -#endif - static int testCompareXMLToArgvFiles(bool shouldFail, const char *poolxml, @@ -46,12 +38,12 @@ testCompareXMLToArgvFiles(bool shouldFail, goto cleanup; } - cmd = virStorageBackendFileSystemMountCmd(MOUNT, def, src); + cmd = virStorageBackendFileSystemMountCmd("mount", def, src); def = NULL; break; case VIR_STORAGE_POOL_LOGICAL: - cmd = virStorageBackendLogicalChangeCmd(VGCHANGE, def, true); + cmd = virStorageBackendLogicalChangeCmd("vgchange", def, true); break; case VIR_STORAGE_POOL_DIR: -- 2.47.3