From 893bca3be56246570720ffceb2bdecd2ddd6d930 Mon Sep 17 00:00:00 2001 From: "Alan T. DeKok" Date: Sat, 11 Jan 2025 10:11:38 -0500 Subject: [PATCH] shut up coverity. CID #1604620 --- src/listen/tacacs/proto_tacacs_tcp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/listen/tacacs/proto_tacacs_tcp.c b/src/listen/tacacs/proto_tacacs_tcp.c index 4493e0bfd6..bebdbaaadf 100644 --- a/src/listen/tacacs/proto_tacacs_tcp.c +++ b/src/listen/tacacs/proto_tacacs_tcp.c @@ -269,6 +269,7 @@ static ssize_t mod_write(fr_listen_t *li, UNUSED void *packet_ctx, UNUSED fr_tim */ fr_assert(buffer_len >= sizeof(fr_tacacs_packet_hdr_t)); fr_assert(written < buffer_len); + fr_assert(buffer_len < (1 << 20)); /* shut up coverity */ /* * @todo - share a stats interface with the parent? or @@ -286,6 +287,8 @@ static ssize_t mod_write(fr_listen_t *li, UNUSED void *packet_ctx, UNUSED fr_tim data_size = write(thread->sockfd, buffer + written, buffer_len - written); if (data_size <= 0) return data_size; + fr_assert((size_t) data_size <= buffer_len); /* shut up coverity */ + /* * If we're supposed to close the socket, then go do that. */ -- 2.47.3