From 8d055b7d61cf691affd30a6ca35eb74171289f1c Mon Sep 17 00:00:00 2001
From: Pavel Hrdina <phrdina@redhat.com>
Date: Thu, 6 Mar 2025 10:42:11 +0100
Subject: [PATCH] domain_conf: graphics: use a function to format audio element
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Removes code duplication.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 src/conf/domain_conf.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 9fb8a9e8d3..f8de0b0e6f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -26412,6 +26412,16 @@ virDomainGraphicsDefFormatGL(virBuffer *buf,
     virBufferAddLit(buf, "/>\n");
 }
 
+static void
+virDomainGraphicsDefFormatAudio(virBuffer *buf,
+                                unsigned int audioId)
+{
+    if (audioId <= 0)
+        return;
+
+    virBufferAsprintf(buf, "<audio id='%d'/>\n", audioId);
+}
+
 static int
 virDomainGraphicsDefFormat(virBuffer *buf,
                            virDomainGraphicsDef *def,
@@ -26629,9 +26639,7 @@ virDomainGraphicsDefFormat(virBuffer *buf,
 
         virDomainGraphicsDefFormatGL(buf, def->data.dbus.gl, def->data.dbus.rendernode);
 
-        if (def->data.dbus.audioId > 0)
-            virBufferAsprintf(buf, "<audio id='%d'/>\n",
-                              def->data.dbus.audioId);
+        virDomainGraphicsDefFormatAudio(buf, def->data.dbus.audioId);
 
         break;
     case VIR_DOMAIN_GRAPHICS_TYPE_LAST:
@@ -26732,9 +26740,7 @@ virDomainGraphicsDefFormat(virBuffer *buf,
             children = true;
         }
 
-        if (def->data.vnc.audioId > 0)
-            virBufferAsprintf(buf, "<audio id='%d'/>\n",
-                              def->data.vnc.audioId);
+        virDomainGraphicsDefFormatAudio(buf, def->data.vnc.audioId);
     }
 
     if (children) {
-- 
2.47.3