From 8d07bfd434f2f37f6e7e4ed6d165446cc6884f98 Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Thu, 24 Sep 2015 15:55:08 -0400 Subject: [PATCH] plugins: free views that can't load Trying to use an unloaded view can lead to crashes. If a view can't be loaded, free it right away. --- src/plugins/splash/fade-throbber/plugin.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/plugins/splash/fade-throbber/plugin.c b/src/plugins/splash/fade-throbber/plugin.c index 00410dea..aba2cc62 100644 --- a/src/plugins/splash/fade-throbber/plugin.c +++ b/src/plugins/splash/fade-throbber/plugin.c @@ -295,8 +295,12 @@ load_views (ply_boot_splash_plugin_t *plugin) view = ply_list_node_get_data (node); next_node = ply_list_get_next_node (plugin->views, node); - if (view_load (view)) + if (view_load (view)) { view_loaded = true; + } else { + ply_list_remove_node (plugin->views, node); + view_free (view); + } node = next_node; } -- 2.47.3