From 8dd706557a57a86b4ffa438dddc93a04a0c865a4 Mon Sep 17 00:00:00 2001 From: Ben Zhang Date: Fri, 7 Dec 2018 16:08:21 -0500 Subject: [PATCH] fix: correctly remove the event listener in _destroy --- js/foundation.smoothScroll.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/js/foundation.smoothScroll.js b/js/foundation.smoothScroll.js index a58d6c428..6280c39ec 100644 --- a/js/foundation.smoothScroll.js +++ b/js/foundation.smoothScroll.js @@ -39,8 +39,9 @@ class SmoothScroll extends Plugin { * @private */ _events() { - this.$element.on('click.zf.smoothScroll', this._handleLinkClick.bind(this)); - this.$element.on('click.zf.smoothScroll', 'a[href^="#"]', this._handleLinkClick.bind(this)); + this._linkClickListenner = this._handleLinkClick.bind(this); + this.$element.on('click.zf.smoothScroll', this._linkClickListenner); + this.$element.on('click.zf.smoothScroll', 'a[href^="#"]', this._linkClickListenner); } /** @@ -97,8 +98,8 @@ class SmoothScroll extends Plugin { * @function */ _destroy() { - this.$element.off('click.zf.smoothScroll', this._handleLinkClick) - this.$element.off('click.zf.smoothScroll', 'a[href^="#"]', this._handleLinkClick); + this.$element.off('click.zf.smoothScroll', this._linkClickListenner) + this.$element.off('click.zf.smoothScroll', 'a[href^="#"]', this._linkClickListenner); } } -- 2.47.3