From 8fc71d2e4be85eaa5478e15c6f49600842f0af28 Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Mon, 30 May 2022 00:25:51 -0400 Subject: [PATCH] Fixes for 4.19 Signed-off-by: Sasha Levin --- ...derx-allow-driver-to-work-with-acpi-.patch | 36 ++++++++ ...-a-dma-buffer-for-interrupt-cause-lo.patch | 88 ++++++++++++++++++ ...-encryption-module-availability-cons.patch | 55 +++++++++++ ...disable-hardware-checksum-on-ast2600.patch | 92 +++++++++++++++++++ queue-4.19/series | 4 + 5 files changed, 275 insertions(+) create mode 100644 queue-4.19/drivers-i2c-thunderx-allow-driver-to-work-with-acpi-.patch create mode 100644 queue-4.19/i2c-ismt-provide-a-dma-buffer-for-interrupt-cause-lo.patch create mode 100644 queue-4.19/net-af_key-check-encryption-module-availability-cons.patch create mode 100644 queue-4.19/net-ftgmac100-disable-hardware-checksum-on-ast2600.patch diff --git a/queue-4.19/drivers-i2c-thunderx-allow-driver-to-work-with-acpi-.patch b/queue-4.19/drivers-i2c-thunderx-allow-driver-to-work-with-acpi-.patch new file mode 100644 index 00000000000..f8ff7eb662c --- /dev/null +++ b/queue-4.19/drivers-i2c-thunderx-allow-driver-to-work-with-acpi-.patch @@ -0,0 +1,36 @@ +From 068e350f5784116f419c813f5b5acc5f331b14fd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 11 May 2022 06:36:59 -0700 +Subject: drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI + controllers + +From: Piyush Malgujar + +[ Upstream commit 03a35bc856ddc09f2cc1f4701adecfbf3b464cb3 ] + +Due to i2c->adap.dev.fwnode not being set, ACPI_COMPANION() wasn't properly +found for TWSI controllers. + +Signed-off-by: Szymon Balcerak +Signed-off-by: Piyush Malgujar +Signed-off-by: Wolfram Sang +Signed-off-by: Sasha Levin +--- + drivers/i2c/busses/i2c-thunderx-pcidrv.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/i2c/busses/i2c-thunderx-pcidrv.c b/drivers/i2c/busses/i2c-thunderx-pcidrv.c +index 19f8eec38717..107aeb8b54da 100644 +--- a/drivers/i2c/busses/i2c-thunderx-pcidrv.c ++++ b/drivers/i2c/busses/i2c-thunderx-pcidrv.c +@@ -208,6 +208,7 @@ static int thunder_i2c_probe_pci(struct pci_dev *pdev, + i2c->adap.bus_recovery_info = &octeon_i2c_recovery_info; + i2c->adap.dev.parent = dev; + i2c->adap.dev.of_node = pdev->dev.of_node; ++ i2c->adap.dev.fwnode = dev->fwnode; + snprintf(i2c->adap.name, sizeof(i2c->adap.name), + "Cavium ThunderX i2c adapter at %s", dev_name(dev)); + i2c_set_adapdata(&i2c->adap, i2c); +-- +2.35.1 + diff --git a/queue-4.19/i2c-ismt-provide-a-dma-buffer-for-interrupt-cause-lo.patch b/queue-4.19/i2c-ismt-provide-a-dma-buffer-for-interrupt-cause-lo.patch new file mode 100644 index 00000000000..3b001dcee97 --- /dev/null +++ b/queue-4.19/i2c-ismt-provide-a-dma-buffer-for-interrupt-cause-lo.patch @@ -0,0 +1,88 @@ +From de9d278c248e7a9a4af5e090dc75df7ceb57e4ad Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 27 Apr 2022 13:19:10 +0300 +Subject: i2c: ismt: Provide a DMA buffer for Interrupt Cause Logging + +From: Mika Westerberg + +[ Upstream commit 17a0f3acdc6ec8b89ad40f6e22165a4beee25663 ] + +Before sending a MSI the hardware writes information pertinent to the +interrupt cause to a memory location pointed by SMTICL register. This +memory holds three double words where the least significant bit tells +whether the interrupt cause of master/target/error is valid. The driver +does not use this but we need to set it up because otherwise it will +perform DMA write to the default address (0) and this will cause an +IOMMU fault such as below: + + DMAR: DRHD: handling fault status reg 2 + DMAR: [DMA Write] Request device [00:12.0] PASID ffffffff fault addr 0 + [fault reason 05] PTE Write access is not set + +To prevent this from happening, provide a proper DMA buffer for this +that then gets mapped by the IOMMU accordingly. + +Signed-off-by: Mika Westerberg +Reviewed-by: From: Andy Shevchenko +Signed-off-by: Wolfram Sang +Signed-off-by: Sasha Levin +--- + drivers/i2c/busses/i2c-ismt.c | 14 ++++++++++++++ + 1 file changed, 14 insertions(+) + +diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c +index 0d1c3ec8cb40..80796061102f 100644 +--- a/drivers/i2c/busses/i2c-ismt.c ++++ b/drivers/i2c/busses/i2c-ismt.c +@@ -80,6 +80,7 @@ + + #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */ + #define ISMT_MAX_RETRIES 3 /* number of SMBus retries to attempt */ ++#define ISMT_LOG_ENTRIES 3 /* number of interrupt cause log entries */ + + /* Hardware Descriptor Constants - Control Field */ + #define ISMT_DESC_CWRL 0x01 /* Command/Write Length */ +@@ -173,6 +174,8 @@ struct ismt_priv { + u8 head; /* ring buffer head pointer */ + struct completion cmp; /* interrupt completion */ + u8 buffer[I2C_SMBUS_BLOCK_MAX + 16]; /* temp R/W data buffer */ ++ dma_addr_t log_dma; ++ u32 *log; + }; + + /** +@@ -406,6 +409,9 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr, + memset(desc, 0, sizeof(struct ismt_desc)); + desc->tgtaddr_rw = ISMT_DESC_ADDR_RW(addr, read_write); + ++ /* Always clear the log entries */ ++ memset(priv->log, 0, ISMT_LOG_ENTRIES * sizeof(u32)); ++ + /* Initialize common control bits */ + if (likely(pci_dev_msi_enabled(priv->pci_dev))) + desc->control = ISMT_DESC_INT | ISMT_DESC_FAIR; +@@ -695,6 +701,8 @@ static void ismt_hw_init(struct ismt_priv *priv) + /* initialize the Master Descriptor Base Address (MDBA) */ + writeq(priv->io_rng_dma, priv->smba + ISMT_MSTR_MDBA); + ++ writeq(priv->log_dma, priv->smba + ISMT_GR_SMTICL); ++ + /* initialize the Master Control Register (MCTRL) */ + writel(ISMT_MCTRL_MEIE, priv->smba + ISMT_MSTR_MCTRL); + +@@ -784,6 +792,12 @@ static int ismt_dev_init(struct ismt_priv *priv) + priv->head = 0; + init_completion(&priv->cmp); + ++ priv->log = dmam_alloc_coherent(&priv->pci_dev->dev, ++ ISMT_LOG_ENTRIES * sizeof(u32), ++ &priv->log_dma, GFP_KERNEL); ++ if (!priv->log) ++ return -ENOMEM; ++ + return 0; + } + +-- +2.35.1 + diff --git a/queue-4.19/net-af_key-check-encryption-module-availability-cons.patch b/queue-4.19/net-af_key-check-encryption-module-availability-cons.patch new file mode 100644 index 00000000000..b16184ad8ed --- /dev/null +++ b/queue-4.19/net-af_key-check-encryption-module-availability-cons.patch @@ -0,0 +1,55 @@ +From ef3571048f140b568ca8332e4e0fe533400ded17 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 18 May 2022 08:32:18 +0200 +Subject: net: af_key: check encryption module availability consistency + +From: Thomas Bartschies + +[ Upstream commit 015c44d7bff3f44d569716117becd570c179ca32 ] + +Since the recent introduction supporting the SM3 and SM4 hash algos for IPsec, the kernel +produces invalid pfkey acquire messages, when these encryption modules are disabled. This +happens because the availability of the algos wasn't checked in all necessary functions. +This patch adds these checks. + +Signed-off-by: Thomas Bartschies +Signed-off-by: Steffen Klassert +Signed-off-by: Sasha Levin +--- + net/key/af_key.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/net/key/af_key.c b/net/key/af_key.c +index 170960ef7e36..1bbb6ec89ff3 100644 +--- a/net/key/af_key.c ++++ b/net/key/af_key.c +@@ -2910,7 +2910,7 @@ static int count_ah_combs(const struct xfrm_tmpl *t) + break; + if (!aalg->pfkey_supported) + continue; +- if (aalg_tmpl_set(t, aalg)) ++ if (aalg_tmpl_set(t, aalg) && aalg->available) + sz += sizeof(struct sadb_comb); + } + return sz + sizeof(struct sadb_prop); +@@ -2928,7 +2928,7 @@ static int count_esp_combs(const struct xfrm_tmpl *t) + if (!ealg->pfkey_supported) + continue; + +- if (!(ealg_tmpl_set(t, ealg))) ++ if (!(ealg_tmpl_set(t, ealg) && ealg->available)) + continue; + + for (k = 1; ; k++) { +@@ -2939,7 +2939,7 @@ static int count_esp_combs(const struct xfrm_tmpl *t) + if (!aalg->pfkey_supported) + continue; + +- if (aalg_tmpl_set(t, aalg)) ++ if (aalg_tmpl_set(t, aalg) && aalg->available) + sz += sizeof(struct sadb_comb); + } + } +-- +2.35.1 + diff --git a/queue-4.19/net-ftgmac100-disable-hardware-checksum-on-ast2600.patch b/queue-4.19/net-ftgmac100-disable-hardware-checksum-on-ast2600.patch new file mode 100644 index 00000000000..0495c3beac6 --- /dev/null +++ b/queue-4.19/net-ftgmac100-disable-hardware-checksum-on-ast2600.patch @@ -0,0 +1,92 @@ +From 2877bc9199dd8b316ae73306adb5dc90c9f5282b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 17 May 2022 18:52:17 +0930 +Subject: net: ftgmac100: Disable hardware checksum on AST2600 + +From: Joel Stanley + +[ Upstream commit 6fd45e79e8b93b8d22fb8fe22c32fbad7e9190bd ] + +The AST2600 when using the i210 NIC over NC-SI has been observed to +produce incorrect checksum results with specific MTU values. This was +first observed when sending data across a long distance set of networks. + +On a local network, the following test was performed using a 1MB file of +random data. + +On the receiver run this script: + + #!/bin/bash + while [ 1 ]; do + # Zero the stats + nstat -r > /dev/null + nc -l 9899 > test-file + # Check for checksum errors + TcpInCsumErrors=$(nstat | grep TcpInCsumErrors) + if [ -z "$TcpInCsumErrors" ]; then + echo No TcpInCsumErrors + else + echo TcpInCsumErrors = $TcpInCsumErrors + fi + done + +On an AST2600 system: + + # nc 9899 < test-file + +The test was repeated with various MTU values: + + # ip link set mtu 1410 dev eth0 + +The observed results: + + 1500 - good + 1434 - bad + 1400 - good + 1410 - bad + 1420 - good + +The test was repeated after disabling tx checksumming: + + # ethtool -K eth0 tx-checksumming off + +And all MTU values tested resulted in transfers without error. + +An issue with the driver cannot be ruled out, however there has been no +bug discovered so far. + +David has done the work to take the original bug report of slow data +transfer between long distance connections and triaged it down to this +test case. + +The vendor suspects this this is a hardware issue when using NC-SI. The +fixes line refers to the patch that introduced AST2600 support. + +Reported-by: David Wilder +Reviewed-by: Dylan Hung +Signed-off-by: Joel Stanley +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/faraday/ftgmac100.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c +index 964407deca35..23c019d1278c 100644 +--- a/drivers/net/ethernet/faraday/ftgmac100.c ++++ b/drivers/net/ethernet/faraday/ftgmac100.c +@@ -1869,6 +1869,11 @@ static int ftgmac100_probe(struct platform_device *pdev) + /* AST2400 doesn't have working HW checksum generation */ + if (np && (of_device_is_compatible(np, "aspeed,ast2400-mac"))) + netdev->hw_features &= ~NETIF_F_HW_CSUM; ++ ++ /* AST2600 tx checksum with NCSI is broken */ ++ if (priv->use_ncsi && of_device_is_compatible(np, "aspeed,ast2600-mac")) ++ netdev->hw_features &= ~NETIF_F_HW_CSUM; ++ + if (np && of_get_property(np, "no-hw-checksum", NULL)) + netdev->hw_features &= ~(NETIF_F_HW_CSUM | NETIF_F_RXCSUM); + netdev->features |= netdev->hw_features; +-- +2.35.1 + diff --git a/queue-4.19/series b/queue-4.19/series index 9b582ddbf50..2ee605c2ba6 100644 --- a/queue-4.19/series +++ b/queue-4.19/series @@ -4,3 +4,7 @@ tcp-change-source-port-randomizarion-at-connect-time.patch secure_seq-use-the-64-bits-of-the-siphash-for-port-offset-calculation.patch acpi-sysfs-make-sparse-happy-about-address-space-in-use.patch acpi-sysfs-fix-bert-error-region-memory-mapping.patch +net-af_key-check-encryption-module-availability-cons.patch +net-ftgmac100-disable-hardware-checksum-on-ast2600.patch +i2c-ismt-provide-a-dma-buffer-for-interrupt-cause-lo.patch +drivers-i2c-thunderx-allow-driver-to-work-with-acpi-.patch -- 2.47.3