From 910a5167201f3f51a2875a8c905a9ad58db9ff51 Mon Sep 17 00:00:00 2001 From: Timo Sirainen Date: Tue, 14 Oct 2014 16:57:13 -0700 Subject: [PATCH] imap-zlib: Removed check for disallowing COMPRESS to be used with TLS compression. Clients shouldn't be doing this in any case, and this check doesn't work properly with proxies. We could solve the check properly for Dovecot proxies by having them send the TLS compression state to backends, but it would still leave non-Dovecot proxies broken. Although we could just not advertise COMPRESS=DEFLATE extension if TLS compression is enabled and non-Dovecot proxies at least wouldn't cause failures. Still, overall seems like a lot of work for such a small and probably unnecessary extra check. --- src/plugins/imap-zlib/imap-zlib-plugin.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/plugins/imap-zlib/imap-zlib-plugin.c b/src/plugins/imap-zlib/imap-zlib-plugin.c index 48852ab9cb..631842b73d 100644 --- a/src/plugins/imap-zlib/imap-zlib-plugin.c +++ b/src/plugins/imap-zlib/imap-zlib-plugin.c @@ -87,11 +87,6 @@ static bool cmd_compress(struct client_command_context *cmd) t_str_ucase(zclient->handler->name))); return TRUE; } - if (client->tls_compression) { - client_send_tagline(cmd, - "NO [COMPRESSIONACTIVE] TLS compression already enabled."); - return TRUE; - } handler = compression_lookup_handler(t_str_lcase(mechanism)); if (handler == NULL || handler->create_istream == NULL) { -- 2.47.3