From 92b0a182fe00da3022516f3cb8f815d527d73652 Mon Sep 17 00:00:00 2001 From: Aaron Merey Date: Tue, 5 Jul 2022 18:11:49 -0400 Subject: [PATCH] gdb-add-index always generates an error when libdebuginfod wasn't compiled in gdb-add-index runs gdb with -iex 'set debuginfod enabled off'. If gdb is not compiled against libdebuginfod this causes an unnecessary error message to be printed to stderr indicating that gdb was not built with debuginfod support. Fix this by changing the 'set debuginfod enabled off' command to a no-op when gdb isn't built with libdebuginfod. --- gdb/debuginfod-support.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c index 9dbe6b5d8b2..5f04a2b38ca 100644 --- a/gdb/debuginfod-support.c +++ b/gdb/debuginfod-support.c @@ -368,7 +368,9 @@ set_debuginfod_enabled (const char *value) #if defined(HAVE_LIBDEBUGINFOD) debuginfod_enabled = value; #else - error (NO_IMPL); + /* Disabling debuginfod when gdb is not built with it is a no-op. */ + if (value != debuginfod_off) + error (NO_IMPL); #endif } -- 2.39.5