From 943eb478803cc2ed6f0b1f5df6f1b20c9ad6245d Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Sun, 28 Feb 2021 07:50:26 +0900 Subject: [PATCH] pgbench: Remove now-dead CState->ecnt MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The last use of ecnt was in 12788ae. It was getting incremented after a backend error without any purpose since then, so let's get rid of it. Author: Kota Miyake Reviewed-by: Álvaro Herrera Discussion: https://postgr.es/m/786c3d9fbe067763d899e78c296f9f0f@oss.nttdata.com --- src/bin/pgbench/pgbench.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c index 627a244fb73..31a4df45f57 100644 --- a/src/bin/pgbench/pgbench.c +++ b/src/bin/pgbench/pgbench.c @@ -427,7 +427,6 @@ typedef struct /* per client collected stats */ int64 cnt; /* client transaction count, for -t */ - int ecnt; /* error count */ } CState; /* @@ -2716,7 +2715,6 @@ sendCommand(CState *st, Command *command) if (r == 0) { pg_log_debug("client %d could not send %s", st->id, command->argv[0]); - st->ecnt++; return false; } else @@ -2828,14 +2826,12 @@ readCommandResponse(CState *st, MetaCommand meta, char *varprefix) if (qrynum == 0) { pg_log_error("client %d command %d: no results", st->id, st->command); - st->ecnt++; return false; } return true; error: - st->ecnt++; PQclear(res); PQclear(next_res); do -- 2.39.5