From 9522ff77961451bca032c348ad601e702166335d Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Wed, 12 Oct 2022 09:40:43 +0200 Subject: [PATCH] libsmartcols: improve debug messages * disable debug for tree-wall; it generates to many messages * fix way how library prints column flags, 0x is more redable Signed-off-by: Karel Zak --- libsmartcols/src/table.c | 2 +- libsmartcols/src/walk.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libsmartcols/src/table.c b/libsmartcols/src/table.c index cab2b455e7..8449c4fae5 100644 --- a/libsmartcols/src/table.c +++ b/libsmartcols/src/table.c @@ -419,7 +419,7 @@ struct libscols_column *scols_table_new_column(struct libscols_table *tb, if (!tb) return NULL; - DBG(TAB, ul_debugobj(tb, "new column name=%s, whint=%g, flags=%d", + DBG(TAB, ul_debugobj(tb, "new column name=%s, whint=%g, flags=0x%04x", name, whint, flags)); cl = scols_new_column(); if (!cl) diff --git a/libsmartcols/src/walk.c b/libsmartcols/src/walk.c index a75fde6a34..0b51fed5fc 100644 --- a/libsmartcols/src/walk.c +++ b/libsmartcols/src/walk.c @@ -11,7 +11,7 @@ static int walk_line(struct libscols_table *tb, { int rc = 0; - DBG(LINE, ul_debugobj(ln, " wall line")); +/* DBG(LINE, ul_debugobj(ln, " wall line")); */ /* we list group children in __scols_print_tree() after tree root node */ if (is_group_member(ln) && is_last_group_member(ln) && has_group_children(ln)) @@ -26,7 +26,7 @@ static int walk_line(struct libscols_table *tb, if (rc == 0 && has_children(ln)) { struct list_head *p; - DBG(LINE, ul_debugobj(ln, " children walk")); +/* DBG(LINE, ul_debugobj(ln, " children walk"));*/ list_for_each(p, &ln->ln_branch) { struct libscols_line *chld = list_entry(p, @@ -38,7 +38,7 @@ static int walk_line(struct libscols_table *tb, } } - DBG(LINE, ul_debugobj(ln, "<- walk line done [rc=%d]", rc)); +/* DBG(LINE, ul_debugobj(ln, "<- walk line done [rc=%d]", rc)); */ return rc; } @@ -90,7 +90,7 @@ int scols_walk_tree(struct libscols_table *tb, struct libscols_iter itr; assert(tb); - DBG(TAB, ul_debugobj(tb, ">> walk start")); +/* DBG(TAB, ul_debugobj(tb, ">> walk start"));*/ /* init */ tb->ngrpchlds_pending = 0; @@ -147,6 +147,6 @@ int scols_walk_tree(struct libscols_table *tb, tb->ngrpchlds_pending = 0; tb->walk_last_done = 0; - DBG(TAB, ul_debugobj(tb, "<< walk end [rc=%d]", rc)); +/* DBG(TAB, ul_debugobj(tb, "<< walk end [rc=%d]", rc));*/ return rc; } -- 2.47.2