From 98c995bdf46d6eaacdb650320e544f5b8d910a06 Mon Sep 17 00:00:00 2001
From: Stefan Kober <stefan.kober@cyberus-technology.de>
Date: Thu, 4 Sep 2025 14:10:29 +0200
Subject: [PATCH] ch: add disk attach helper functions

On-behalf-of: SAP stefan.kober@sap.com
Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---
 po/POTFILES         |   1 +
 src/ch/ch_hotplug.c | 132 ++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 129 insertions(+), 4 deletions(-)

diff --git a/po/POTFILES b/po/POTFILES
index 181a36f541..23da794f84 100644
--- a/po/POTFILES
+++ b/po/POTFILES
@@ -25,6 +25,7 @@ src/ch/ch_domain.c
 src/ch/ch_driver.c
 src/ch/ch_events.c
 src/ch/ch_hostdev.c
+src/ch/ch_hotplug.c
 src/ch/ch_interface.c
 src/ch/ch_monitor.c
 src/ch/ch_process.c
diff --git a/src/ch/ch_hotplug.c b/src/ch/ch_hotplug.c
index c46628e7e9..33b8cb2225 100644
--- a/src/ch/ch_hotplug.c
+++ b/src/ch/ch_hotplug.c
@@ -19,17 +19,141 @@
 #include <config.h>
 
 #include "ch_hotplug.h"
+#include "ch_alias.h"
+#include "ch_domain.h"
+#include "domain_event.h"
+#include "domain_validate.h"
+#include "virlog.h"
 
 #define VIR_FROM_THIS VIR_FROM_CH
 
+VIR_LOG_INIT("ch.ch_hotplug");
+
+static int
+chDomainAddDisk(virCHMonitor *mon,
+                virDomainObj *vm,
+                virDomainDiskDef *disk)
+{
+    if (chAssignDeviceDiskAlias(disk) < 0) {
+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                    _("Assigning disk alias failed"));
+        return -1;
+    }
+
+    if (virCHMonitorAddDisk(mon, disk) < 0) {
+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                    _("Adding disk to domain failed"));
+        return -1;
+    }
+
+    virDomainDiskInsert(vm->def, disk);
+
+    return 0;
+}
+
+static int
+chDomainAttachDeviceLive(virDomainObj *vm,
+                         virDomainDeviceDef *dev)
+{
+    int ret = -1;
+    virCHDomainObjPrivate *priv = vm->privateData;
+    virCHMonitor *mon = priv->monitor;
+
+    switch (dev->type) {
+    case VIR_DOMAIN_DEVICE_DISK: {
+        if (chDomainAddDisk(mon, vm, dev->data.disk) < 0) {
+            break;
+        }
+
+        dev->data.disk = NULL;
+        ret = 0;
+        break;
+    }
+    case VIR_DOMAIN_DEVICE_NET:
+    case VIR_DOMAIN_DEVICE_LEASE:
+    case VIR_DOMAIN_DEVICE_FS:
+    case VIR_DOMAIN_DEVICE_INPUT:
+    case VIR_DOMAIN_DEVICE_HOSTDEV:
+    case VIR_DOMAIN_DEVICE_WATCHDOG:
+    case VIR_DOMAIN_DEVICE_CONTROLLER:
+    case VIR_DOMAIN_DEVICE_REDIRDEV:
+    case VIR_DOMAIN_DEVICE_CHR:
+    case VIR_DOMAIN_DEVICE_RNG:
+    case VIR_DOMAIN_DEVICE_SHMEM:
+    case VIR_DOMAIN_DEVICE_MEMORY:
+    case VIR_DOMAIN_DEVICE_VSOCK:
+    case VIR_DOMAIN_DEVICE_NONE:
+    case VIR_DOMAIN_DEVICE_SOUND:
+    case VIR_DOMAIN_DEVICE_VIDEO:
+    case VIR_DOMAIN_DEVICE_GRAPHICS:
+    case VIR_DOMAIN_DEVICE_HUB:
+    case VIR_DOMAIN_DEVICE_SMARTCARD:
+    case VIR_DOMAIN_DEVICE_MEMBALLOON:
+    case VIR_DOMAIN_DEVICE_NVRAM:
+    case VIR_DOMAIN_DEVICE_TPM:
+    case VIR_DOMAIN_DEVICE_PANIC:
+    case VIR_DOMAIN_DEVICE_IOMMU:
+    case VIR_DOMAIN_DEVICE_AUDIO:
+    case VIR_DOMAIN_DEVICE_CRYPTO:
+    case VIR_DOMAIN_DEVICE_PSTORE:
+    case VIR_DOMAIN_DEVICE_LAST:
+    default:
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
+                       _("live attach of device '%1$s' is not supported"),
+                       virDomainDeviceTypeToString(dev->type));
+        break;
+    }
+
+    return ret;
+}
+
 int
-chDomainAttachDeviceLiveAndUpdateConfig(virDomainObj *vm G_GNUC_UNUSED,
-                                        virCHDriver *driver G_GNUC_UNUSED,
-                                        const char *xml G_GNUC_UNUSED,
+chDomainAttachDeviceLiveAndUpdateConfig(virDomainObj *vm,
+                                        virCHDriver *driver,
+                                        const char *xml,
                                         unsigned int flags)
 {
+    unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE |
+                               VIR_DOMAIN_DEF_PARSE_ABI_UPDATE;
+    g_autoptr(virDomainDeviceDef) devLive = NULL;
+    g_autoptr(virDomainDef) vmdef = NULL;
+    g_autoptr(virCHDriverConfig) cfg = NULL;
+    g_autoptr(virDomainDeviceDef) devConf = NULL;
+
     virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
                   VIR_DOMAIN_AFFECT_CONFIG, -1);
 
-    return -1;
+    cfg = virCHDriverGetConfig(driver);
+
+    if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+                       _("Persistent domain state changes are not supported"));
+        return -1;
+    }
+
+    if (flags & VIR_DOMAIN_AFFECT_LIVE) {
+        if (!(devLive = virDomainDeviceDefParse(xml, vm->def,
+                                                driver->xmlopt, NULL,
+                                                parse_flags))) {
+            return -1;
+        }
+
+        if (virDomainDeviceValidateAliasForHotplug(vm, devLive,
+                                                   VIR_DOMAIN_AFFECT_LIVE) < 0)
+            return -1;
+
+        if (virDomainDefCompatibleDevice(vm->def, devLive, NULL,
+                                        VIR_DOMAIN_DEVICE_ACTION_ATTACH,
+                                        true) < 0) {
+            return -1;
+        }
+
+        if (chDomainAttachDeviceLive(vm, devLive) < 0) {
+            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                        _("Failed to add device"));
+            return -1;
+        }
+    }
+
+    return 0;
 }
-- 
2.47.3