From 9978b6f762e8b165a9180069f194bf278aca0a5c Mon Sep 17 00:00:00 2001 From: Alberto Leiva Popper Date: Thu, 16 May 2024 12:42:12 -0600 Subject: [PATCH] FIX TODO: not validating @alg False alarm; the getter was just redundant. @alg was beind validated at validate_certificate_public_key_algorithm(). --- src/object/certificate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/object/certificate.c b/src/object/certificate.c index 5c83ac66..51dc590f 100644 --- a/src/object/certificate.c +++ b/src/object/certificate.c @@ -451,7 +451,6 @@ validate_public_key(X509 *cert, enum cert_type type) { X509_PUBKEY *pubkey; X509_ALGOR *pa; - ASN1_OBJECT *alg; int ok; int error; @@ -460,8 +459,7 @@ validate_public_key(X509 *cert, enum cert_type type) if (pubkey == NULL) return val_crypto_err("X509_get_X509_PUBKEY() returned NULL"); - /* TODO not validating @alg? */ - ok = X509_PUBKEY_get0_param(&alg, NULL, NULL, &pa, pubkey); + ok = X509_PUBKEY_get0_param(NULL, NULL, NULL, &pa, pubkey); if (!ok) return val_crypto_err("X509_PUBKEY_get0_param() returned %d", ok); -- 2.47.3