From 9a83f3a12aa9652e905ebdd6a64cfb58a3fab5bc Mon Sep 17 00:00:00 2001 From: Francis Dupont Date: Mon, 21 Mar 2016 15:41:51 +0100 Subject: [PATCH] [4306] Added comments about uninitilaized too big arrays --- src/lib/dhcp/tests/pkt4_unittest.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lib/dhcp/tests/pkt4_unittest.cc b/src/lib/dhcp/tests/pkt4_unittest.cc index 23ebff2948..288881b719 100644 --- a/src/lib/dhcp/tests/pkt4_unittest.cc +++ b/src/lib/dhcp/tests/pkt4_unittest.cc @@ -519,7 +519,8 @@ TEST_F(Pkt4Test, sname) { EXPECT_THROW(pkt4.setSname(NULL, Pkt4::MAX_SNAME_LEN), InvalidParameter); EXPECT_THROW(pkt4.setSname(NULL, 0), InvalidParameter); - // Check that a too long argument generates an exception. + // Check that a too long argument generates an exception + // (the actual content doesn't matter). uint8_t bigsname[Pkt4::MAX_SNAME_LEN + 1]; EXPECT_THROW(pkt4.setSname(bigsname, Pkt4::MAX_SNAME_LEN + 1), OutOfRange); } @@ -563,7 +564,8 @@ TEST_F(Pkt4Test, file) { EXPECT_THROW(pkt4.setFile(NULL, Pkt4::MAX_FILE_LEN), InvalidParameter); EXPECT_THROW(pkt4.setFile(NULL, 0), InvalidParameter); - // Check that a too long argument generates an exception. + // Check that a too long argument generates an exception + // (the actual content doesn't matter). uint8_t bigfile[Pkt4::MAX_FILE_LEN + 1]; EXPECT_THROW(pkt4.setFile(bigfile, Pkt4::MAX_FILE_LEN + 1), OutOfRange); } -- 2.47.3