From 9ab57f29c78d8d69b6ba9c579521594d7170ca44 Mon Sep 17 00:00:00 2001 From: Pauli Date: Fri, 14 Oct 2022 12:53:02 +1100 Subject: [PATCH] Coverity 1515953: negative loop bound Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/19413) --- crypto/encode_decode/encoder_pkey.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crypto/encode_decode/encoder_pkey.c b/crypto/encode_decode/encoder_pkey.c index 1a09b01f49b..6954343422a 100644 --- a/crypto/encode_decode/encoder_pkey.c +++ b/crypto/encode_decode/encoder_pkey.c @@ -103,14 +103,15 @@ static void collect_encoder(OSSL_ENCODER *encoder, void *arg) */ if ((data->keymgmt_prov == prov) == data->flag_find_same_provider) { void *provctx = OSSL_PROVIDER_get0_provider_ctx(prov); - size_t i, end_i = sk_OPENSSL_CSTRING_num(data->names); + int i, end_i = sk_OPENSSL_CSTRING_num(data->names); int match; for (i = 0; i < end_i; i++) { if (data->flag_find_same_provider) match = (data->id_names[i] == encoder->base.id); else - match = OSSL_ENCODER_is_a(encoder, sk_OPENSSL_CSTRING_value(data->names, i)); + match = OSSL_ENCODER_is_a(encoder, + sk_OPENSSL_CSTRING_value(data->names, i)); if (!match || (encoder->does_selection != NULL && !encoder->does_selection(provctx, data->ctx->selection)) -- 2.47.2