From 9bf19c09a491f775d0b5ca27fea4c7c551600579 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 8 Sep 2025 15:59:57 +0200 Subject: [PATCH] qemuMigrationSrcIsSafe: Drop 'DEBUG' message about qemu supporting cache dropping MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The feature exists for a long time, no need to add extra notice about it. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_migration.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index a8f4dd489c..dd171f953c 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1805,14 +1805,10 @@ qemuMigrationSrcIsSafe(virDomainObj *vm, * which case cache mode doesn't matter) or used with cache=none or used with cache=directsync */ if (disk->src->shared || disk->cachemode == VIR_DOMAIN_DISK_CACHE_DISABLE || - disk->cachemode == VIR_DOMAIN_DISK_CACHE_DIRECTSYNC) + disk->cachemode == VIR_DOMAIN_DISK_CACHE_DIRECTSYNC || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE)) continue; - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE)) { - VIR_DEBUG("QEMU supports flushing caches; migration is safe"); - continue; - } - virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s", _("Migration may lead to data corruption if disks use cache other than none or directsync")); return false; -- 2.47.3