From 9c02f36e21ed477a824a1d6f73206e6ef40636b1 Mon Sep 17 00:00:00 2001
From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 17 Jan 2023 13:41:44 +0000
Subject: [PATCH] firewall: Avoid creating a rule that permits all traffic on
 invalid source
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

The firewall engine generated rules that did not have any traffic
selectors due to an improperly initialized variable in the source.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Acked-by: Peter Müller <peter.mueller@ipfire.org>
---
 config/firewall/rules.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
index 30ad20df1d..1b628df169 100644
--- a/config/firewall/rules.pl
+++ b/config/firewall/rules.pl
@@ -401,6 +401,9 @@ sub buildrules {
 					$source = "";
 				}
 
+				# Make sure that $source is properly defined
+				next unless (defined $source);
+
 				my $source_intf = @$src[1];
 
 				foreach my $dst (@destinations) {
-- 
2.39.2