From 9c62c979ada334703e017265a352a9c5e8f545b0 Mon Sep 17 00:00:00 2001 From: Alex Rousskov Date: Fri, 9 Jul 2021 15:32:33 +0000 Subject: [PATCH] Bug 4696: Fix leaky String move assignment operator (#858) The original attempt at fixing String move assignment operator (i.e. commit 20a04c1) leaked the assigned-to String object memory. These leaks are measurable even in --disable-optimizations builds. --- src/SquidString.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/SquidString.h b/src/SquidString.h index 3bfaa5989a..30f23285fe 100644 --- a/src/SquidString.h +++ b/src/SquidString.h @@ -42,6 +42,7 @@ public: String &operator =(String const &); String &operator =(String && S) { if (this != &S) { + clean(); size_ = S.size_; len_ = S.len_; buf_ = S.buf_; -- 2.47.3