From 9c64c5d91e98471b44cca0999542c7ebcc385c51 Mon Sep 17 00:00:00 2001 From: Dmitry Antipov Date: Mon, 11 Aug 2025 10:23:25 +0300 Subject: [PATCH] Revert "media: xc2028: avoid use-after-free in load_firmware_cb()" Revert commit 68594cec291f ("media: xc2028: avoid use-after-free in load_firmware_cb()") since it doesn't make sense to check dangling 'struct dvb_frontend *' passed to 'load_firmware_cb()'. Signed-off-by: Dmitry Antipov Signed-off-by: Hans Verkuil --- drivers/media/tuners/xc2028.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/media/tuners/xc2028.c b/drivers/media/tuners/xc2028.c index 8e6638e5f6889..807585d2dfde6 100644 --- a/drivers/media/tuners/xc2028.c +++ b/drivers/media/tuners/xc2028.c @@ -1361,16 +1361,9 @@ static void load_firmware_cb(const struct firmware *fw, void *context) { struct dvb_frontend *fe = context; - struct xc2028_data *priv; + struct xc2028_data *priv = fe->tuner_priv; int rc; - if (!fe) { - pr_warn("xc2028: No frontend in %s\n", __func__); - return; - } - - priv = fe->tuner_priv; - tuner_dbg("request_firmware_nowait(): %s\n", fw ? "OK" : "error"); if (!fw) { tuner_err("Could not load firmware %s.\n", priv->fname); -- 2.47.3