From 9c88e60327bafbce359a0ad6f0025bda403e2ee7 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Mon, 26 May 2025 12:51:49 -0400 Subject: [PATCH] mke2fs: add range checks for -E desc_size Prevent the user from specifying group descriptor that result in invalid/corrupted file systems. Signed-off-by: Theodore Ts'o (cherry picked from commit 326e8ab43503dd9f44338754c84cb03a725ecc49) --- misc/mke2fs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/misc/mke2fs.c b/misc/mke2fs.c index 017838d4..1b7399a5 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -883,7 +883,10 @@ static void parse_extended_opts(struct ext2_super_block *param, continue; } ulong = strtoul(arg, &p, 0); - if (*p || (ulong & (ulong - 1))) { + if (*p || + (ulong < EXT2_MIN_DESC_SIZE_64BIT) || + (ulong > EXT2_MAX_DESC_SIZE) || + (ulong & (ulong - 1))) { fprintf(stderr, _("Invalid desc_size: '%s'\n"), arg); r_usage++; -- 2.47.3