From 9d10f017e2420119455f5fa46db698961786e578 Mon Sep 17 00:00:00 2001 From: Lukas Czerner Date: Wed, 14 Sep 2011 13:27:44 -0400 Subject: [PATCH] e2image: fix invalid lseek error detection In flush_l2_cache() we are using ext2fs_llseek() however we do not properly detect the error code returned from the function, because we are assigning it into ULL variable, hence we will not see negative values. Fix this by changing the type of the variable to ext2_loff_t which is signed and hence will store negative values. Signed-off-by: Lukas Czerner Signed-off-by: "Theodore Ts'o" --- misc/e2image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/misc/e2image.c b/misc/e2image.c index 83a9d0254..bf0c0d436 100644 --- a/misc/e2image.c +++ b/misc/e2image.c @@ -759,7 +759,8 @@ static void put_used_table(struct ext2_qcow2_image *img, static void flush_l2_cache(struct ext2_qcow2_image *image) { - blk64_t offset, seek = 0; + blk64_t seek = 0; + ext2_loff_t offset; struct ext2_qcow2_l2_cache *cache = image->l2_cache; struct ext2_qcow2_l2_table *table = cache->used_head; int fd = image->fd; -- 2.39.5