From 9dc99f951d8e6e9acf644515161da543223e60ce Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 30 Jun 2021 18:38:57 -0400 Subject: [PATCH] xfs: fix return of uninitialized value in variable error Source kernel commit: 3b6dd9a9aeeada19d0c820ff68e979243a888bb6 A previous commit removed a call to xfs_attr3_leaf_read that assigned an error return code to variable error. We now have a few early error return paths to label 'out' that return error if error is set; however error now is uninitialized so potentially garbage is being returned. Fix this by setting error to zero to restore the original behaviour where error was zero at the label 'restart'. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 07120f1abdff ("xfs: Add xfs_has_attr and subroutines") Signed-off-by: Colin Ian King Reviewed-by: Brian Foster Reviewed-by: Darrick J. Wong Signed-off-by: Darrick J. Wong Signed-off-by: Eric Sandeen --- libxfs/xfs_attr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c index f7ed4e267..631818178 100644 --- a/libxfs/xfs_attr.c +++ b/libxfs/xfs_attr.c @@ -928,6 +928,7 @@ restart: * Search to see if name already exists, and get back a pointer * to where it should go. */ + error = 0; retval = xfs_attr_node_hasname(args, &state); if (retval != -ENOATTR && retval != -EEXIST) goto out; -- 2.47.2