From 9dfe80a8157ba5bb403b46f8cdfed2affe716c6b Mon Sep 17 00:00:00 2001 From: Vladimir Oltean Date: Thu, 21 Aug 2025 18:20:21 +0300 Subject: [PATCH] net: phy: aquantia: promote AQR813 and AQR114C to aqr_gen4_config_init() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit I'm not sure whether there is any similar real-life problem on AQR813 and AQR114C as were seen on the PHYs that these commit were written for: - a7f3abcf6357 ("net: phy: aquantia: only poll GLOBAL_CFG regs on aqr113, aqr113c and aqr115c") - bed90b06b681 ("net: phy: aquantia: clear PMD Global Transmit Disable bit during init") but the inconsistency in handling between PHYs of the same generation is striking. Apart from different firmware builds with different provisioning, the only difference between these PHYs should be the max link speed and/or the number of ports. Let's try and see if there's any problem if all PHYs from the same generation use the same config_init() method. Cc: Bartosz Golaszewski Cc: Robert Marko Cc: Paweł Owoc Cc: Christian Marangi Signed-off-by: Vladimir Oltean Link: https://patch.msgid.link/20250821152022.1065237-15-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski --- drivers/net/phy/aquantia/aquantia_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c index eb4409fdad347..dd83205a8869c 100644 --- a/drivers/net/phy/aquantia/aquantia_main.c +++ b/drivers/net/phy/aquantia/aquantia_main.c @@ -1324,7 +1324,7 @@ static struct phy_driver aqr_driver[] = { .name = "Aquantia AQR114C", .probe = aqr107_probe, .get_rate_matching = aqr_gen2_get_rate_matching, - .config_init = aqr_gen2_config_init, + .config_init = aqr_gen4_config_init, .config_aneg = aqr_config_aneg, .config_intr = aqr_config_intr, .handle_interrupt = aqr_handle_interrupt, @@ -1374,7 +1374,7 @@ static struct phy_driver aqr_driver[] = { .name = "Aquantia AQR813", .probe = aqr107_probe, .get_rate_matching = aqr_gen2_get_rate_matching, - .config_init = aqr_gen2_config_init, + .config_init = aqr_gen4_config_init, .config_aneg = aqr_config_aneg, .config_intr = aqr_config_intr, .handle_interrupt = aqr_handle_interrupt, -- 2.47.3