From b64335ff111c071fde61aec1c1a8460afb3d16d4 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Thu, 6 Nov 2025 14:49:21 +0100 Subject: [PATCH] support: Exit on consistency check failure in resolv_response_add_name Using TEST_VERIFY (crname_target != crname) instructs some analysis tools that crname_target == crname might hold. Under this assumption, they report a use-after-free for crname_target->offset below, caused by the previous free (crname). Reviewed-by: Collin Funk --- support/resolv_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/resolv_test.c b/support/resolv_test.c index ab37d3d58c..29e59da958 100644 --- a/support/resolv_test.c +++ b/support/resolv_test.c @@ -326,7 +326,7 @@ resolv_response_add_name (struct resolv_response_builder *b, crname_target = *ptr; else crname_target = NULL; - TEST_VERIFY (crname_target != crname); + TEST_VERIFY_EXIT (crname_target != crname); /* Not added to the tree. */ free (crname); } -- 2.47.3