From a037ede37f97729665387cdec0018314ecfdedb3 Mon Sep 17 00:00:00 2001 From: Timo Sirainen Date: Mon, 4 Oct 2021 14:42:54 +0300 Subject: [PATCH] lib: buffer_free() - Check for buf==NULL before using container_of() Helps with static analyzer complaints. --- src/lib/buffer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lib/buffer.c b/src/lib/buffer.c index 55f230b321..f6f3a0f9ec 100644 --- a/src/lib/buffer.c +++ b/src/lib/buffer.c @@ -184,10 +184,9 @@ buffer_t *buffer_create_dynamic_max(pool_t pool, size_t init_size, void buffer_free(buffer_t **_buf) { - struct real_buffer *buf = container_of(*_buf, struct real_buffer, buf); - - if (buf == NULL) + if (*_buf == NULL) return; + struct real_buffer *buf = container_of(*_buf, struct real_buffer, buf); *_buf = NULL; if (buf->alloced) -- 2.47.3