From a5a44aba3f0e21753314ca6cfd766083a22b387f Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Wed, 1 Apr 2015 11:16:40 -0400 Subject: [PATCH] remove assignment in conditional --- Modules/socketmodule.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c index e9e4479a6678..cbc3223d9894 100644 --- a/Modules/socketmodule.c +++ b/Modules/socketmodule.c @@ -4207,7 +4207,8 @@ socket_getaddrinfo(PyObject *self, PyObject *args) goto err; } - if ((all = PyList_New(0)) == NULL) + all = PyList_New(0); + if (all == NULL) goto err; for (res = res0; res; res = res->ai_next) { PyObject *addr = -- 2.47.3