From a5ffdc8debf342ea2f917b24c8f64aa0edc30076 Mon Sep 17 00:00:00 2001 From: Timo Sirainen Date: Mon, 13 Jun 2022 09:56:13 +0300 Subject: [PATCH] doveadm deduplicate: Allocate memory properly for keys in hash table This caused wrong mails to be deleted somewhat randomly. Broken by 320844f50cd669b602d30210e2e5216f65d2050f --- src/doveadm/doveadm-mail-deduplicate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/doveadm/doveadm-mail-deduplicate.c b/src/doveadm/doveadm-mail-deduplicate.c index abe41559fb..f990287d7f 100644 --- a/src/doveadm/doveadm-mail-deduplicate.c +++ b/src/doveadm/doveadm-mail-deduplicate.c @@ -61,8 +61,10 @@ cmd_deduplicate_box(struct doveadm_mail_cmd_context *_ctx, if (key != NULL && *key != '\0') { if (hash_table_lookup(hash, key) != NULL) mail_expunge(mail); - else + else { + key = p_strdup(pool, key); hash_table_insert(hash, key, POINTER_CAST(1)); + } } } -- 2.47.3