From a6a12282c49e006d3a6fc06297f39b84fe409deb Mon Sep 17 00:00:00 2001 From: Jukka Kurkela Date: Tue, 16 Feb 2021 17:26:22 +0200 Subject: [PATCH] Fix memory leak on destroy (#8438) --- src/core/core.config.js | 6 +++++- src/core/core.controller.js | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/core/core.config.js b/src/core/core.config.js index a0562faad..309cf75fc 100644 --- a/src/core/core.config.js +++ b/src/core/core.config.js @@ -156,9 +156,13 @@ export default class Config { update(options) { const config = this._config; + this.clearCache(); + config.options = initOptions(config, options); + } + + clearCache() { this._scopeCache.clear(); this._resolverCache.clear(); - config.options = initOptions(config, options); } /** diff --git a/src/core/core.controller.js b/src/core/core.controller.js index b84b22c33..3e9151a0f 100644 --- a/src/core/core.controller.js +++ b/src/core/core.controller.js @@ -831,6 +831,8 @@ class Chart { me._destroyDatasetMeta(i); } + me.config.clearCache(); + if (canvas) { me.unbindEvents(); clearCanvas(canvas, ctx); -- 2.47.3