From a6f052670ac388a24ff004f67ff045427aeb85e1 Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Sun, 27 Sep 2015 10:32:28 +0200 Subject: [PATCH] Check return value of snprintf in mount_proc_if_needed() Signed-off-by: Christian Brauner Acked-by: Serge E. Hallyn --- src/lxc/utils.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lxc/utils.c b/src/lxc/utils.c index 5250c6217..788cbe136 100644 --- a/src/lxc/utils.c +++ b/src/lxc/utils.c @@ -1664,6 +1664,10 @@ int mount_proc_if_needed(const char *rootfs) mypid = (int)getpid(); INFO("I am %d, /proc/self points to '%s'", mypid, link); ret = snprintf(path, MAXPATHLEN, "%s/proc", rootfs); + if (ret < 0 || ret >= MAXPATHLEN) { + SYSERROR("proc path name too long"); + return -1; + } if (linklen < 0) /* /proc not mounted */ goto domount; if (atoi(link) != mypid) { -- 2.47.3