From a6f9cd0707544be90bb622098e1f7271b60e8423 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Wed, 18 Sep 2024 16:49:08 +0100 Subject: [PATCH] tools/rmmod: consistently use ERR logging facility Currently we'll print "Module foo is in use by:" to syslog, while the modules themselves will end up in strerr. Signed-off-by: Emil Velikov Link: https://github.com/kmod-project/kmod/pull/138 Signed-off-by: Lucas De Marchi --- tools/rmmod.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/rmmod.c b/tools/rmmod.c index b56416c2..2d82c860 100644 --- a/tools/rmmod.c +++ b/tools/rmmod.c @@ -69,10 +69,10 @@ static int check_module_inuse(struct kmod_module *mod) { kmod_list_foreach(itr, holders) { struct kmod_module *hm = kmod_module_get_module(itr); - fprintf(stderr, " %s", kmod_module_get_name(hm)); + ERR(" %s", kmod_module_get_name(hm)); kmod_module_unref(hm); } - fputc('\n', stderr); + ERR("\n"); kmod_module_unref_list(holders); return -EBUSY; -- 2.47.2