From a7035a8ee96648bfbd2cd747308bca41122500ab Mon Sep 17 00:00:00 2001 From: Jarkko Nikula Date: Wed, 9 Apr 2025 17:03:59 +0300 Subject: [PATCH] i3c: mipi-i3c-hci: Clear INTR_STATUS unconditionally Status fields in INTR_STATUS register are write 1 to clear so do it unconditionally and move clearing of them out of an if block. Suggested-by: Frank Li Signed-off-by: Jarkko Nikula Reviewed-by: Frank Li Link: https://lore.kernel.org/r/20250409140401.299251-3-jarkko.nikula@linux.intel.com Signed-off-by: Alexandre Belloni --- drivers/i3c/master/mipi-i3c-hci/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c index 780e9db7e21e4..4c4100d2d9afa 100644 --- a/drivers/i3c/master/mipi-i3c-hci/core.c +++ b/drivers/i3c/master/mipi-i3c-hci/core.c @@ -590,12 +590,11 @@ static irqreturn_t i3c_hci_irq_handler(int irq, void *dev_id) u32 val; val = reg_read(INTR_STATUS); + reg_write(INTR_STATUS, val); DBG("INTR_STATUS = %#x", val); - if (val) { - reg_write(INTR_STATUS, val); + if (val) result = IRQ_HANDLED; - } if (val & INTR_HC_RESET_CANCEL) { DBG("cancelled reset"); -- 2.39.5