From aaad75e2cbfaf2e3c7df9129714b3f03befd128c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 22 Aug 1999 10:53:13 +0000 Subject: [PATCH] (run_shell): Declare with noreturn attribute. Use an explicit exit(1) rather than doing that through error. --- login-utils/su.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/login-utils/su.c b/login-utils/su.c index 0f5efd22d8..1a871f8503 100644 --- a/login-utils/su.c +++ b/login-utils/su.c @@ -154,6 +154,8 @@ char *xstrdup (); extern char **environ; +static void run_shell (const char *, const char *, char **) ATTRIBUTE_NORETURN; + /* The name this program was run with. */ char *program_name; @@ -398,7 +400,8 @@ run_shell (const char *shell, const char *command, char **additional_args) args[argno++] = *additional_args; args[argno] = NULL; execv (shell, (char **) args); - error (1, errno, _("cannot run %s"), shell); + error (0, errno, _("cannot run %s"), shell); + exit (1); } /* Return 1 if SHELL is a restricted shell (one not returned by -- 2.47.2