From aabc02b30ac664395aaaed5dd626b5813986291e Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Fri, 2 May 2014 09:32:59 +1000 Subject: [PATCH] mkfs.xfs: prevent close(-1) on protofile error path My previous cleanups introduced this; in the case where fd=open() failed, the out_fail: path would try to close(-1). Signed-off-by: Eric Sandeen Reviewed-by: Mark Tinguely Signed-off-by: Dave Chinner --- mkfs/proto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mkfs/proto.c b/mkfs/proto.c index 308325be2..5a47e27c0 100644 --- a/mkfs/proto.c +++ b/mkfs/proto.c @@ -84,7 +84,8 @@ setup_proto( return buf; out_fail: - close(fd); + if (fd >= 0) + close(fd); free(buf); exit(1); } -- 2.47.2