From ab37a96d075907ecb857b4d983761db1af102598 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Thomas=20Wei=C3=9Fschuh?= Date: Fri, 22 Sep 2023 11:19:24 +0200 Subject: [PATCH] ci: don't combine -Werror and -fsanitize MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit As explained in [0]: Note that sanitizers tend to increase the rate of false positive warnings, most notably those around -Wmaybe-uninitialized. We recommend against combining -Werror and [the use of] sanitizers. [0] https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gcc/Instrumentation-Options.html#index-fsanitize_003dundefined Signed-off-by: Thomas Weißschuh --- .github/workflows/cibuild.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cibuild.sh b/.github/workflows/cibuild.sh index 6bb10862f4..dfcf91c757 100755 --- a/.github/workflows/cibuild.sh +++ b/.github/workflows/cibuild.sh @@ -83,7 +83,6 @@ for phase in "${PHASES[@]}"; do --disable-use-tty-group --disable-makeinstall-chown --enable-all-programs - --enable-werror ) if [[ "$COVERAGE" == "yes" ]]; then @@ -94,6 +93,8 @@ for phase in "${PHASES[@]}"; do opts+=(--enable-asan --enable-ubsan) CFLAGS+=(-fno-omit-frame-pointer) CXXFLAGS+=(-fno-omit-frame-pointer) + else + opts+=(--enable-werror) fi if [[ "$COMPILER" == clang* && "$SANITIZE" == "yes" ]]; then -- 2.47.3