From adc7641536a93fbcbd7b96502313b8b65c89c575 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Mon, 8 Aug 2022 16:09:46 +0200 Subject: [PATCH] MINOR: quic: Too much useless traces in qc_build_frms() These traces about the available room into the packet currently built and its payload length could be displayed for each STREAM frame, even for those which have no chance to be embedded into a packet leading to very traces to be displayed from a connection with a lot of stream. This was revealed by traces provide by Tristan in GH #1808 May be backported to 2.6. --- src/xprt_quic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xprt_quic.c b/src/xprt_quic.c index 75788e17ba..3705608485 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -5925,11 +5925,11 @@ static inline int qc_build_frms(struct list *outlist, struct list *inlist, ((cf->type & QUIC_STREAM_FRAME_TYPE_OFF_BIT) ? quic_int_getsize(cf->stream.offset.key) : 0); /* Compute the data length of this STREAM frame. */ avail_room = room - hlen - *len; - TRACE_PROTO(" New STREAM frame build (room, len)", - QUIC_EV_CONN_BCFRMS, qc, &room, len); if ((ssize_t)avail_room <= 0) continue; + TRACE_PROTO(" New STREAM frame build (room, len)", + QUIC_EV_CONN_BCFRMS, qc, &room, len); if (cf->type & QUIC_STREAM_FRAME_TYPE_LEN_BIT) { dlen = max_available_room(avail_room, &dlen_sz); if (dlen > cf->stream.len) { -- 2.47.3