From ae174ae97d3274cb168a87e445348845b1da07a2 Mon Sep 17 00:00:00 2001 From: "Alan T. DeKok" Date: Fri, 10 May 2024 20:16:25 -0400 Subject: [PATCH] try to satisfy clang scan, too --- src/lib/server/module.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lib/server/module.c b/src/lib/server/module.c index 3b1a5a8a38..4182f8650a 100644 --- a/src/lib/server/module.c +++ b/src/lib/server/module.c @@ -421,7 +421,7 @@ static void mlg_data_del(module_instance_t *mi) mlg_module_instance_t *mlg_mi = (mlg_module_instance_t *)talloc_get_type_abort(mi, module_instance_t); if (!fr_heap_entry_inserted(mlg_mi->inst_idx)) return; - + if (fr_heap_extract(&mlg_index, mi) == 0) return; fr_assert(0); @@ -683,6 +683,11 @@ static int8_t module_instance_name_cmp(void const *one, void const *two) int a_depth = 0, b_depth = 0; int ret; +#ifdef STATIC_ANALYZER + if (!fr_cond_assert(a)) return +1; + if (!fr_cond_assert(b)) return -1; +#endif + /* * Sort by depth, so for tree walking we start * at the shallowest node, and finish with -- 2.47.3