From afeccd48a738ebae5645dded4dd13f053747d008 Mon Sep 17 00:00:00 2001 From: Filipe Brandenburger Date: Mon, 2 May 2016 12:18:47 -0700 Subject: [PATCH] config: Fix check for argp_parse to pass &argv Right now it's passing a char* when it expects a char** instead. This usually produces a warning that may go unnoticed, but if CFLAGS contains -Werror, that breaks the ./configure run with the following error: $ ./configure CFLAGS=-Werror ... configure: WARNING: "libc does not have argp" checking for argp_parse in -largp... no configure: error: "no libargp found" Tested: Checked that after this fix, running ./configure CFLAGS=-Werror works as expected and argp_parse is correctly detected. Signed-off-by: Filipe Brandenburger --- ChangeLog | 4 ++++ configure.ac | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 31f346f36..f2b5c8fa1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2016-05-02 Filipe Brandenburger + + * configure.ac (argp check): Pass pass &argv. + 2016-03-31 Mark Wielaard * configure.ac: Set version to 0.166. diff --git a/configure.ac b/configure.ac index 86a69c66f..72cb22e82 100644 --- a/configure.ac +++ b/configure.ac @@ -340,7 +340,7 @@ dnl Check if we have argp available from our libc AC_LINK_IFELSE( [AC_LANG_PROGRAM( [#include ], - [int argc=1; char *argv[]={"test"}; argp_parse(0,argc,argv,0,0,0); return 0;] + [int argc=1; char *argv[]={"test"}; argp_parse(0,argc,&argv,0,0,0); return 0;] )], [libc_has_argp="true"], [libc_has_argp="false"] -- 2.47.3