From b5b7e0238af259848996cf79b763600e2b76a14a Mon Sep 17 00:00:00 2001 From: Florian Krohm Date: Fri, 26 Sep 2025 22:01:46 +0000 Subject: [PATCH] Fix file permissions. The following files do not need to be executable: - configure.ac - Makefile*am - *.in The following files lack execute permission: - tests/platform_test - tests/vg_regtest - perf/vg_perf So from now on you can just run tests/vg_regtest and perf/vg_perf without the perl prefix. Docs changed accordingly. --- Makefile.all.am | 0 README_DEVELOPERS | 44 +++++++++---------- cachegrind/cg_annotate.in | 0 cachegrind/cg_diff.in | 0 cachegrind/cg_merge.in | 0 configure.ac | 6 ++- coregrind/link_tool_exe_freebsd.in | 0 coregrind/vgstack.in | 0 drd/scripts/download-and-build-splash2.in | 0 drd/tests/Makefile.am | 0 drd/tests/filter_error_count.in | 0 drd/tests/filter_error_summary.in | 0 drd/tests/filter_stderr.in | 0 .../filter_stderr_and_thread_no_and_offset.in | 0 drd/tests/filter_thread_no.in | 0 drd/tests/filter_xml_and_thread_no.in | 0 gdbserver_tests/Makefile.am | 0 gdbserver_tests/README_DEVELOPERS | 4 +- gdbserver_tests/filter_gdb.in | 0 gdbserver_tests/filter_memcheck_monitor.in | 0 gdbserver_tests/filter_stderr.in | 0 gdbserver_tests/filter_vgdb.in | 0 helgrind/tests/Makefile.am | 0 helgrind/tests/filter_stderr.in | 0 massif/ms_print.in | 0 memcheck/tests/filter_dw4.in | 0 memcheck/tests/filter_overlaperror.in | 0 memcheck/tests/filter_stderr.in | 0 memcheck/tests/filter_supp.in | 0 memcheck/tests/x86/filter_pushfpopf.in | 0 tests/filter_discards.in | 0 tests/filter_stderr_basic.in | 0 tests/platform_test | 0 tests/vg_regtest.in | 2 +- 34 files changed, 29 insertions(+), 27 deletions(-) mode change 100755 => 100644 Makefile.all.am mode change 100755 => 100644 cachegrind/cg_annotate.in mode change 100755 => 100644 cachegrind/cg_diff.in mode change 100755 => 100644 cachegrind/cg_merge.in mode change 100755 => 100644 configure.ac mode change 100755 => 100644 coregrind/link_tool_exe_freebsd.in mode change 100755 => 100644 coregrind/vgstack.in mode change 100755 => 100644 drd/scripts/download-and-build-splash2.in mode change 100755 => 100644 drd/tests/Makefile.am mode change 100755 => 100644 drd/tests/filter_error_count.in mode change 100755 => 100644 drd/tests/filter_error_summary.in mode change 100755 => 100644 drd/tests/filter_stderr.in mode change 100755 => 100644 drd/tests/filter_stderr_and_thread_no_and_offset.in mode change 100755 => 100644 drd/tests/filter_thread_no.in mode change 100755 => 100644 drd/tests/filter_xml_and_thread_no.in mode change 100755 => 100644 gdbserver_tests/Makefile.am mode change 100755 => 100644 gdbserver_tests/filter_gdb.in mode change 100755 => 100644 gdbserver_tests/filter_memcheck_monitor.in mode change 100755 => 100644 gdbserver_tests/filter_stderr.in mode change 100755 => 100644 gdbserver_tests/filter_vgdb.in mode change 100755 => 100644 helgrind/tests/Makefile.am mode change 100755 => 100644 helgrind/tests/filter_stderr.in mode change 100755 => 100644 massif/ms_print.in mode change 100755 => 100644 memcheck/tests/filter_dw4.in mode change 100755 => 100644 memcheck/tests/filter_overlaperror.in mode change 100755 => 100644 memcheck/tests/filter_stderr.in mode change 100755 => 100644 memcheck/tests/filter_supp.in mode change 100755 => 100644 memcheck/tests/x86/filter_pushfpopf.in mode change 100755 => 100644 tests/filter_discards.in mode change 100755 => 100644 tests/filter_stderr_basic.in mode change 100644 => 100755 tests/platform_test mode change 100755 => 100644 tests/vg_regtest.in diff --git a/Makefile.all.am b/Makefile.all.am old mode 100755 new mode 100644 diff --git a/README_DEVELOPERS b/README_DEVELOPERS index fc5a801295..22e229bd49 100644 --- a/README_DEVELOPERS +++ b/README_DEVELOPERS @@ -53,15 +53,15 @@ To build and run all the regression tests, run "make [--quiet] regtest". To run a subset of the regression tests, execute: - perl tests/vg_regtest + tests/vg_regtest where is a directory (all tests within will be run) or a single .vgtest test file, or the name of a program which has a like-named .vgtest file. Eg: - perl tests/vg_regtest memcheck - perl tests/vg_regtest memcheck/tests/badfree.vgtest - perl tests/vg_regtest memcheck/tests/badfree + tests/vg_regtest memcheck + tests/vg_regtest memcheck/tests/badfree.vgtest + tests/vg_regtest memcheck/tests/badfree The details of each vgtest run are logged to individual "vgtest.log" files. These are listed, and non-passing tests detailed, in the @@ -114,22 +114,22 @@ To build and run all the performance tests, run "make [--quiet] perf". To run a subset of the performance suite, execute: - perl perf/vg_perf + perf/vg_perf where is a directory (all tests within will be run) or a single .vgperf test file, or the name of a program which has a like-named .vgperf file. Eg: - perl perf/vg_perf perf/ - perl perf/vg_perf perf/bz2.vgperf - perl perf/vg_perf perf/bz2 + perf/vg_perf perf/ + perf/vg_perf perf/bz2.vgperf + perf/vg_perf perf/bz2 To compare multiple versions of Valgrind, use the --vg= option multiple times. For example, if you have two Valgrinds next to each other, one in trunk1/ and one in trunk2/, from within either trunk1/ or trunk2/ do this to compare them on all the performance tests: - perl perf/vg_perf --vg=../trunk1 --vg=../trunk2 perf/ + perf/vg_perf --vg=../trunk1 --vg=../trunk2 perf/ Writing regression tests ~~~~~~~~~~~~~~~~~~~~~~~~ @@ -183,7 +183,7 @@ See tests/vg_regtest for a full description of all possible vgtest directives. The easiest way to generate the expected files is to run the test. Create empty files with touch (otherwise the test won't run) then run the test from the -top directory using perl and vg_regtest script (as in the "Running the +top directory using vg_regtest script (as in the "Running the regression tests" section. Then copy "tool/tests/newtest.stderr.out" to "tool/tests/newtest.stderr.exp". It is better to generate the .stdout.exp file directly from the testcase. You can do that by redirecting stdout to @@ -402,16 +402,16 @@ When using self-hosting with an outer Callgrind tool, use '--pop-on-jump' (B) Regression tests in an outer/inner setup: To run all the regression tests with an outer memcheck, do : - perl tests/vg_regtest --outer-valgrind=../outer/.../bin/valgrind \ - --all + tests/vg_regtest --outer-valgrind=../outer/.../bin/valgrind \ + --all To run a specific regression tests with an outer memcheck, do: - perl tests/vg_regtest --outer-valgrind=../outer/.../bin/valgrind \ - none/tests/args.vgtest + tests/vg_regtest --outer-valgrind=../outer/.../bin/valgrind \ + none/tests/args.vgtest To run regression tests with another outer tool: - perl tests/vg_regtest --outer-valgrind=../outer/.../bin/valgrind \ - --outer-tool=helgrind --all + tests/vg_regtest --outer-valgrind=../outer/.../bin/valgrind \ + --outer-tool=helgrind --all --outer-args allows to give specific arguments to the outer tool, replacing the default one provided by vg_regtest. @@ -470,20 +470,20 @@ the guest stacktrace that did the allocation. (C) Performance tests in an outer/inner setup: To run all the performance tests with an outer cachegrind, do : - perl perf/vg_perf --outer-valgrind=../outer/.../bin/valgrind perf + perf/vg_perf --outer-valgrind=../outer/.../bin/valgrind perf To run a specific perf test (e.g. bz2) in this setup, do : - perl perf/vg_perf --outer-valgrind=../outer/.../bin/valgrind perf/bz2 + perf/vg_perf --outer-valgrind=../outer/.../bin/valgrind perf/bz2 To run all the performance tests with an outer callgrind, do : - perl perf/vg_perf --outer-valgrind=../outer/.../bin/valgrind \ - --outer-tool=callgrind perf + perf/vg_perf --outer-valgrind=../outer/.../bin/valgrind \ + --outer-tool=callgrind perf Note: --outer-valgrind must be a "make install"-ed valgrind. Do *not* use vg-in-place. To compare the performance of multiple Valgrind versions, do : - perl perf/vg_perf --outer-valgrind=../outer/.../bin/valgrind \ + perf/vg_perf --outer-valgrind=../outer/.../bin/valgrind \ --outer-tool=callgrind \ --vg=../inner_xxxx --vg=../inner_yyyy perf (where inner_xxxx and inner_yyyy are the toplevel directories of @@ -498,7 +498,7 @@ output files will be created for each test: (where tt is the two letters abbreviation for the inner tool(s) run). For example, the command - perl perf/vg_perf \ + perf/vg_perf \ --outer-valgrind=../outer_trunk/install/bin/valgrind \ --outer-tool=callgrind \ --vg=../inner_tchain --vg=../inner_trunk perf/many-loss-records diff --git a/cachegrind/cg_annotate.in b/cachegrind/cg_annotate.in old mode 100755 new mode 100644 diff --git a/cachegrind/cg_diff.in b/cachegrind/cg_diff.in old mode 100755 new mode 100644 diff --git a/cachegrind/cg_merge.in b/cachegrind/cg_merge.in old mode 100755 new mode 100644 diff --git a/configure.ac b/configure.ac old mode 100755 new mode 100644 index 1e7d506557..1a7ea34d1b --- a/configure.ac +++ b/configure.ac @@ -5752,9 +5752,7 @@ AC_CONFIG_FILES([ docs/Makefile docs/xml/vg-entities.xml tests/Makefile - tests/vg_regtest perf/Makefile - perf/vg_perf gdbserver_tests/Makefile gdbserver_tests/solaris/Makefile include/Makefile @@ -5860,6 +5858,10 @@ AC_CONFIG_FILES([tests/filter_stderr_basic], [chmod +x tests/filter_stderr_basic]) AC_CONFIG_FILES([tests/filter_discards], [chmod +x tests/filter_discards]) +AC_CONFIG_FILES([tests/vg_regtest], + [chmod +x tests/vg_regtest]) +AC_CONFIG_FILES([perf/vg_perf], + [chmod +x perf/vg_perf]) AC_CONFIG_FILES([memcheck/tests/filter_stderr], [chmod +x memcheck/tests/filter_stderr]) AC_CONFIG_FILES([memcheck/tests/filter_dw4], diff --git a/coregrind/link_tool_exe_freebsd.in b/coregrind/link_tool_exe_freebsd.in old mode 100755 new mode 100644 diff --git a/coregrind/vgstack.in b/coregrind/vgstack.in old mode 100755 new mode 100644 diff --git a/drd/scripts/download-and-build-splash2.in b/drd/scripts/download-and-build-splash2.in old mode 100755 new mode 100644 diff --git a/drd/tests/Makefile.am b/drd/tests/Makefile.am old mode 100755 new mode 100644 diff --git a/drd/tests/filter_error_count.in b/drd/tests/filter_error_count.in old mode 100755 new mode 100644 diff --git a/drd/tests/filter_error_summary.in b/drd/tests/filter_error_summary.in old mode 100755 new mode 100644 diff --git a/drd/tests/filter_stderr.in b/drd/tests/filter_stderr.in old mode 100755 new mode 100644 diff --git a/drd/tests/filter_stderr_and_thread_no_and_offset.in b/drd/tests/filter_stderr_and_thread_no_and_offset.in old mode 100755 new mode 100644 diff --git a/drd/tests/filter_thread_no.in b/drd/tests/filter_thread_no.in old mode 100755 new mode 100644 diff --git a/drd/tests/filter_xml_and_thread_no.in b/drd/tests/filter_xml_and_thread_no.in old mode 100755 new mode 100644 diff --git a/gdbserver_tests/Makefile.am b/gdbserver_tests/Makefile.am old mode 100755 new mode 100644 diff --git a/gdbserver_tests/README_DEVELOPERS b/gdbserver_tests/README_DEVELOPERS index c570f3e531..250c14326b 100644 --- a/gdbserver_tests/README_DEVELOPERS +++ b/gdbserver_tests/README_DEVELOPERS @@ -15,7 +15,7 @@ or (to just run the gdbserver tests with another gdb): make check cd .. gdbserver_tests/make_local_links /path/to/another/gdb - perl tests/vg_regtest gdbserver_tests + tests/vg_regtest gdbserver_tests The minimum version to run the tests is gdb >= 6.5. Previous versions do not have the 'target remote |' command. It @@ -45,7 +45,7 @@ You are welcome to fix such bugs by enhancing filter_gdb. Alternatively, to report such problems, the best is to re-run the gdbserver tests the following way: - perl tests/vg_regtest --keep-unfiltered gdbserver_tests + tests/vg_regtest --keep-unfiltered gdbserver_tests Then file a bug in bugzilla, giving the following information: output of diff --git a/gdbserver_tests/filter_gdb.in b/gdbserver_tests/filter_gdb.in old mode 100755 new mode 100644 diff --git a/gdbserver_tests/filter_memcheck_monitor.in b/gdbserver_tests/filter_memcheck_monitor.in old mode 100755 new mode 100644 diff --git a/gdbserver_tests/filter_stderr.in b/gdbserver_tests/filter_stderr.in old mode 100755 new mode 100644 diff --git a/gdbserver_tests/filter_vgdb.in b/gdbserver_tests/filter_vgdb.in old mode 100755 new mode 100644 diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am old mode 100755 new mode 100644 diff --git a/helgrind/tests/filter_stderr.in b/helgrind/tests/filter_stderr.in old mode 100755 new mode 100644 diff --git a/massif/ms_print.in b/massif/ms_print.in old mode 100755 new mode 100644 diff --git a/memcheck/tests/filter_dw4.in b/memcheck/tests/filter_dw4.in old mode 100755 new mode 100644 diff --git a/memcheck/tests/filter_overlaperror.in b/memcheck/tests/filter_overlaperror.in old mode 100755 new mode 100644 diff --git a/memcheck/tests/filter_stderr.in b/memcheck/tests/filter_stderr.in old mode 100755 new mode 100644 diff --git a/memcheck/tests/filter_supp.in b/memcheck/tests/filter_supp.in old mode 100755 new mode 100644 diff --git a/memcheck/tests/x86/filter_pushfpopf.in b/memcheck/tests/x86/filter_pushfpopf.in old mode 100755 new mode 100644 diff --git a/tests/filter_discards.in b/tests/filter_discards.in old mode 100755 new mode 100644 diff --git a/tests/filter_stderr_basic.in b/tests/filter_stderr_basic.in old mode 100755 new mode 100644 diff --git a/tests/platform_test b/tests/platform_test old mode 100644 new mode 100755 diff --git a/tests/vg_regtest.in b/tests/vg_regtest.in old mode 100755 new mode 100644 index 3471322b0f..945b4c1617 --- a/tests/vg_regtest.in +++ b/tests/vg_regtest.in @@ -692,7 +692,7 @@ sub test_one_dir($$) if (256 == system("$tests_dir/tests/arch_test $dir")) { return; } if (256 == system("$tests_dir/tests/os_test $dir")) { return; } if ($dir =~ /(\w+)-(\w+)/ && - 256 == system("sh $tests_dir/tests/platform_test $1 $2")) { return; } + 256 == system("$tests_dir/tests/platform_test $1 $2")) { return; } if ($dir =~ "dSYM") { return; } chdir($dir) or die "Could not change into $dir\n"; -- 2.47.3