From b6bb4e0e62facb1f787e2e269182a5ce5b5cfdf9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Cristian=20Rodr=C3=ADguez?= Date: Mon, 27 Jul 2020 10:11:33 -0400 Subject: [PATCH] use O_TMPFILE if it works/is supported in __archive_mktemp This makes the function safer on linux since the file is warrantied to never be visible on the filesystem, cannot be linked anywhere unless O_EXCL is not specified and it is lost forever on any kind of program termination. --- libarchive/archive_util.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libarchive/archive_util.c b/libarchive/archive_util.c index c76ecc5b0..b1582edbe 100644 --- a/libarchive/archive_util.c +++ b/libarchive/archive_util.c @@ -433,6 +433,11 @@ __archive_mktemp(const char *tmpdir) if (temp_name.s[temp_name.length-1] != '/') archive_strappend_char(&temp_name, '/'); } +#ifdef O_TMPFILE + fd = open(temp_name.s, O_RDWR|O_CLOEXEC|O_TMPFILE|O_EXCL, 0600); + if(fd >= 0) + goto exit_tmpfile; +#endif archive_strcat(&temp_name, "libarchive_XXXXXX"); fd = mkstemp(temp_name.s); if (fd < 0) -- 2.47.2