From b8eddda8524bf6f164361667bfce6bbb3fac846b Mon Sep 17 00:00:00 2001 From: Lev Stipakov Date: Fri, 17 Feb 2023 14:21:55 +0200 Subject: [PATCH] Avoid management log loop with verb >= 6 This log message is printed within check_tls(), which is called by pre_select(), which is called on every iteration of event loop. When management is attached (and doesn't use own event loop), this message sets management state to "wait write", which arms event loop. When on the next iteration iowait returns with "management write event is set", we call pre_select() and print that message again, causing the loop. Fix by simply removing this log message. Signed-off-by: Lev Stipakov Acked-by: Antonio Quartulli Message-Id: <20230217122156.541-1-lstipakov@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26284.html Signed-off-by: Gert Doering --- src/openvpn/dco.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index 3087a0df8..b53332a87 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -133,8 +133,6 @@ dco_get_secondary_key(struct tls_multi *multi, const struct key_state *primary) bool dco_update_keys(dco_context_t *dco, struct tls_multi *multi) { - msg(D_DCO_DEBUG, "%s: peer_id=%d", __func__, multi->dco_peer_id); - /* this function checks if keys have to be swapped or erased, therefore it * can't do much if we don't have any key installed */ -- 2.47.3