From b998a8e670a9d174103e875d158e6521b0fbbf53 Mon Sep 17 00:00:00 2001 From: Guillaume-Jean Herbiet Date: Tue, 21 May 2024 21:57:21 +0200 Subject: [PATCH] dnsdist: Clarify server status methods and attributes documentation Detail return values for `Server:isUp()` method and `Server.upStatus` attribute to clarify behavior when the server is administratively set UP or DOWN. Closes #14217 --- pdns/dnsdistdist/docs/reference/config.rst | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pdns/dnsdistdist/docs/reference/config.rst b/pdns/dnsdistdist/docs/reference/config.rst index 8967187a07..bdc748a71a 100644 --- a/pdns/dnsdistdist/docs/reference/config.rst +++ b/pdns/dnsdistdist/docs/reference/config.rst @@ -806,7 +806,9 @@ A server object returned by :func:`getServer` can be manipulated with these func .. method:: Server:isUp() -> bool - Returns the up status of the server + Returns the up status of the server. + Result is based on the administrative status of the server (as set by either :meth:`Server:setDown` or :meth:`Server:setUp`). + If no administrative status is set, result is based on :attr:`Server.upStatus` :returns: true when the server is up, false otherwise @@ -825,7 +827,7 @@ A server object returned by :func:`getServer` can be manipulated with these func .. method:: Server:setDown() - Set the server in a ``DOWN`` state. + Administratively set the server in a ``DOWN`` state. The server will not receive queries and the health checks are disabled. .. method:: Server:setLazyAuto([status]) @@ -846,7 +848,7 @@ A server object returned by :func:`getServer` can be manipulated with these func .. method:: Server:setUp() - Set the server in an ``UP`` state. + Administratively set the server in an ``UP`` state. This server will still receive queries and health checks are disabled Apart from the functions, a :class:`Server` object has these attributes: @@ -857,7 +859,7 @@ A server object returned by :func:`getServer` can be manipulated with these func .. attribute:: Server.upStatus - Whether or not this server is up or down + Whether or not this server is ``up`` (true) or ``down`` (false) based on the last known state of heatlh-checks. .. attribute:: Server.order -- 2.47.2