From be14b683af735071f5b35b643620973e0588ad98 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 16 Aug 2024 11:43:33 -0600 Subject: [PATCH] Fix Windows regression commit cb9f919f ("gdb: add program_space parameter to lookup_minimal_symbol_text") caused a crash on Windows. In this function, section can be nullptr, but it is unconditionally dereferenced by the change introduced by the patch. I tested this using the AdaCore internal test suite. v2: always use current_program_space, reverting to be behavior before cb9f919f. Approved-By: Simon Marchi --- gdb/symtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index 9b3562eeb30..ce5e2520bd1 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -3174,7 +3174,7 @@ find_pc_sect_line (CORE_ADDR pc, struct obj_section *section, int notcurrent) if (msymbol.minsym->type () == mst_solib_trampoline) { bound_minimal_symbol mfunsym - = lookup_minimal_symbol_text (section->objfile->pspace (), + = lookup_minimal_symbol_text (current_program_space, msymbol.minsym->linkage_name (), nullptr); -- 2.39.5