From bea8658fe2d60dc82c0ff4f703df0a9e5408e96f Mon Sep 17 00:00:00 2001 From: Stephan Bosch Date: Sun, 16 Sep 2018 21:55:58 +0200 Subject: [PATCH] lib-smtp: params: Fix segfault occurring in smtp_param_write() when param->value == NULL. --- src/lib-smtp/smtp-params.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lib-smtp/smtp-params.c b/src/lib-smtp/smtp-params.c index 3c8178ef58..8e9786f765 100644 --- a/src/lib-smtp/smtp-params.c +++ b/src/lib-smtp/smtp-params.c @@ -100,10 +100,12 @@ static bool smtp_param_value_valid(const char *value) void smtp_param_write(string_t *out, const struct smtp_param *param) { - i_assert(smtp_param_value_valid(param->value)); str_append(out, t_str_ucase(param->keyword)); - str_append_c(out, '='); - str_append(out, param->value); + if (param->value != NULL) { + i_assert(smtp_param_value_valid(param->value)); + str_append_c(out, '='); + str_append(out, param->value); + } } /* -- 2.47.3