From bf09c64ada53254b8c54c610b510788d7ae5651f Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Mon, 5 Dec 2011 10:32:41 -0700 Subject: [PATCH] spec: add dmidecode as prereq https://bugzilla.redhat.com/show_bug.cgi?id=754909 complains that because libvirt didn't require dmidecode, that the logs are noisy and virConnectGetSysinfo needlessly fails. Even 'virt-what' requires dmidecode, so it's not that onerous of a dependency. We may be able to drop this in the future when we move to parsing sysfs data, but for now, listing the dependency will help matters. * libvirt.spec.in (Requires): Sort Requires before BuildRequires. Add dmidecode. (cherry picked from commit e7dfa468f9de796430a4cc9594eb256109a517bf) extra requires for with_systemd removed, since the patch that adds that hasn't been backported --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5cb87fb9b2..ba950c6244 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -326,6 +326,8 @@ Requires: device-mapper %if %{with_cgconfig} Requires: libcgroup %endif +# For virConnectGetSysinfo +Requires: dmidecode # All build-time requirements BuildRequires: python-devel -- 2.47.3