From bf4bf9f144e1b16dbf36ccbbbf91395ad7b9706f Mon Sep 17 00:00:00 2001 From: =?utf8?q?G=C3=BCnther=20Deschner?= Date: Tue, 12 Aug 2025 14:37:06 +0200 Subject: [PATCH] s3-utils: Fix CID #1517309 Resource leak in net offlinejoin code. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Guenther Signed-off-by: Guenther Deschner Reviewed-by: Andreas Schneider Autobuild-User(master): Günther Deschner Autobuild-Date(master): Wed Aug 13 01:51:11 UTC 2025 on atb-devel-224 --- source3/utils/net_offlinejoin.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source3/utils/net_offlinejoin.c b/source3/utils/net_offlinejoin.c index e7ea518659c..135625ec800 100644 --- a/source3/utils/net_offlinejoin.c +++ b/source3/utils/net_offlinejoin.c @@ -320,6 +320,7 @@ int net_offlinejoin_requestodj(struct net_context *c, if (provision_bin_data_size > UINT32_MAX) { d_printf("provision binary data size too big: %zu\n", provision_bin_data_size); + TALLOC_FREE(provision_bin_data); return -1; } @@ -331,11 +332,14 @@ int net_offlinejoin_requestodj(struct net_context *c, /* NERR_JoinPerformedMustRestart */ printf("Failed to call NetRequestOfflineDomainJoin: %s\n", libnetapi_get_error_string(c->netapi_ctx, status)); + TALLOC_FREE(provision_bin_data); return -1; } d_printf("Successfully requested Offline Domain Join\n"); + TALLOC_FREE(provision_bin_data); + return 0; } -- 2.47.3