From c0f42f4d76a1477b6603f4e9bc91c854dcc8f343 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Thu, 20 Nov 2025 04:30:31 -0500 Subject: [PATCH] tools: allow passing details for passed validation tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In a number of virt-host-validte tests we are testing for at least one out of multiple acceptable features. For example the 'secure guest' test can be satisfied by s390x protvirt, or x86 TDX, SEV, SEV-ES, SEV-SNP. It would be useful to inform the user which one we detected when the test passes. This introduces virValidatePassDetails to enable that. Reviewed-by: Peter Krempa Signed-off-by: Daniel P. Berrangé --- tools/virt-validate-common.c | 12 +++++++++++- tools/virt-validate-common.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/virt-validate-common.c b/tools/virt-validate-common.c index 9768fd9208..ef6130ff2a 100644 --- a/tools/virt-validate-common.c +++ b/tools/virt-validate-common.c @@ -62,14 +62,24 @@ static bool virValidateWantEscape(void) } void virValidatePass(void) +{ + virValidatePassDetails(NULL); +} + +void virValidatePassDetails(const char *info) { if (quiet) return; if (virValidateWantEscape()) - fprintf(stdout, "\033[32m%s\033[0m\n", _("PASS")); + fprintf(stdout, "\033[32m%s\033[0m", _("PASS")); else fprintf(stdout, "%s\n", _("PASS")); + + if (info) + fprintf(stdout, " (%s)\n", info); + else + fprintf(stdout, "\n"); } diff --git a/tools/virt-validate-common.h b/tools/virt-validate-common.h index 7f7c373a66..8981f5af71 100644 --- a/tools/virt-validate-common.h +++ b/tools/virt-validate-common.h @@ -52,6 +52,7 @@ void virValidateCheck(const char *prefix, ...) G_GNUC_PRINTF(2, 3); void virValidatePass(void); +void virValidatePassDetails(const char *info); void virValidateFail(virValidateLevel level, const char *format, ...) G_GNUC_PRINTF(2, 3); -- 2.47.3