From c13d3128fdf314fc8b550c9cf03fe673b33ce32f Mon Sep 17 00:00:00 2001 From: Stephan Bosch Date: Mon, 11 Dec 2017 10:41:53 +0100 Subject: [PATCH] lib-smtp: server: Remove useless o_stream_flush() in smtp_server_connection_disconnect(). This is already performed implicitly by o_stream_uncork(). Fixes a problem found by Coverity. --- src/lib-smtp/smtp-server-connection.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lib-smtp/smtp-server-connection.c b/src/lib-smtp/smtp-server-connection.c index 145df3e6b4..f9355258f7 100644 --- a/src/lib-smtp/smtp-server-connection.c +++ b/src/lib-smtp/smtp-server-connection.c @@ -1014,10 +1014,8 @@ smtp_server_connection_disconnect(struct smtp_server_connection *conn, smtp_server_connection_update_stats(conn); smtp_server_connection_timeout_stop(conn); - if (conn->conn.output != NULL) { - o_stream_flush(conn->conn.output); + if (conn->conn.output != NULL) o_stream_uncork(conn->conn.output); - } if (conn->smtp_parser != NULL) smtp_command_parser_deinit(&conn->smtp_parser); if (conn->ssl_iostream != NULL) -- 2.47.3