From c2178d87c2fe524913d2ae059be2b3622ad7bd08 Mon Sep 17 00:00:00 2001
From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Fri, 19 Aug 2022 16:50:54 +1200
Subject: [PATCH] py/getopt: improve messages for bad --realm

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---
 python/samba/getopt.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/python/samba/getopt.py b/python/samba/getopt.py
index 76bee5e9b7f..76c48de87b6 100644
--- a/python/samba/getopt.py
+++ b/python/samba/getopt.py
@@ -74,7 +74,10 @@ class SambaOptions(optparse.OptionGroup):
         parser.values.debuglevel = arg
 
     def _set_realm(self, option, opt_str, arg, parser):
-        self._lp.set('realm', arg)
+        try:
+            self._lp.set('realm', arg)
+        except RuntimeError:
+            raise OptionError(f"invalid --realm value: '{arg}'")
         self.realm = arg
 
     def _set_option(self, option, opt_str, arg, parser):
-- 
2.47.3