From c39115a3f83ceceb31d7ebba4af9b65bde6de737 Mon Sep 17 00:00:00 2001 From: "Gary V. Vaughan" Date: Wed, 9 Jun 2010 19:34:34 +0700 Subject: [PATCH] Fix a quoting bug with ./commit -a 'A U Thor'. * clcommit.m4sh (func_commit): Use func_show_eval when calling git, so that the previously func_quote_for_eval()ed $git_flags is expanded properly. Signed-off-by: Gary V. Vaughan --- ChangeLog | 7 +++++++ clcommit.m4sh | 13 +++---------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 054399949..a1bc4653a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-06-09 Gary V. Vaughan + + Fix a quoting bug with ./commit -a 'A U Thor'. + * clcommit.m4sh (func_commit): Use func_show_eval when calling + git, so that the previously func_quote_for_eval()ed $git_flags is + expanded properly. + 2009-09-15 Peter Rosin Don't try the MSYS libdir path on MinGW. diff --git a/clcommit.m4sh b/clcommit.m4sh index 93d5f9924..6157cd295 100644 --- a/clcommit.m4sh +++ b/clcommit.m4sh @@ -266,18 +266,11 @@ func_commit () test $# -gt 0 && subject="$@" test $# -gt 0 || { set dummy -a; shift; } - func_verbose "$GIT commit $git_flags -F $log_file ${1+$@}" - $opt_dry_run || - $GIT commit $git_flags -F $log_file ${1+"$@"} || exit $EXIT_FAILURE + func_show_eval "$GIT commit $git_flags -F $log_file ${1+$@}" "exit $EXIT_FAILURE" $opt_push && { - func_verbose "$GIT push" - $opt_dry_run || $GIT push - - $opt_tags && { - func_verbose "$GIT push --tags" - $opt_dry_run || $GIT push --tags - } + func_show_eval "$GIT push" + $opt_tags && func_show_eval "$GIT push --tags" } : -- 2.47.3